Skip to content
Snippets Groups Projects

Dealing with minor TODOs

Merged Fabian Seidl requested to merge check-and-fulfill-todos-in-code-2 into master
8 files
+ 19
19
Compare changes
  • Side-by-side
  • Inline
Files
8
@@ -52,7 +52,6 @@ func (yh *AssignForwardingHandler) Update(c ygot.ValidatedGoStruct, jobs []*gnmi
@@ -52,7 +52,6 @@ func (yh *AssignForwardingHandler) Update(c ygot.ValidatedGoStruct, jobs []*gnmi
var nextHopString string
var nextHopString string
var prevHopString string
var prevHopString string
var initiatingKmsAddressString string
if nextHop != nil {
if nextHop != nil {
nextHopString = nextHop.GetNodeId()
nextHopString = nextHop.GetNodeId()
@@ -73,10 +72,10 @@ func (yh *AssignForwardingHandler) Update(c ygot.ValidatedGoStruct, jobs []*gnmi
@@ -73,10 +72,10 @@ func (yh *AssignForwardingHandler) Update(c ygot.ValidatedGoStruct, jobs []*gnmi
log.Error("initiatingKmsAddress must have either an IP address or a hostname")
log.Error("initiatingKmsAddress must have either an IP address or a hostname")
return fmt.Errorf("initiatingKmsAddress must have either an IP address or a hostname")
return fmt.Errorf("initiatingKmsAddress must have either an IP address or a hostname")
}
}
initiatingKmsAddressString = fmt.Sprintf("%s:%d", addressPrefix, initiatingKmsAddress.GetPort())
initKMS = &kms.RemoteKMS{
initKMS = &kms.RemoteKMS{
Id: initiatingKmsAddress.GetNodeId(),
Id: initiatingKmsAddress.GetNodeId(),
Address: initiatingKmsAddressString,
Address: addressPrefix,
Port: initiatingKmsAddress.GetPort(),
Port: initiatingKmsAddress.GetPort(),
}
}
}
}
Loading