Resolve "Investigate if TransportOption and Transport are both required when creating network elements"
Merged
requested to merge 310-investigate-if-transportoption-and-transport-are-both-required-when-creating-network-elements into master
All threads resolved!
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
-
Bug fix (non-breaking change which fixes an issue) -
New feature (non-breaking change which adds functionality) -
Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
-
My code follows the code style of this project. -
My change requires a change to the documentation. -
I have updated the documentation accordingly. -
I have read the CONTRIBUTING document. -
I have added tests to cover my changes. -
All new and existing tests passed.
Related to #310
Merge request reports
Activity
added componentdatabase goSDN prioritylow statusavailable typeinvestigation labels
assigned to @hda11249
- Resolved by Fabian Seidl
Was thinking about this for a while and am not sure if we should keep storing
transportType
in the storage or not. Maybe in the future, it would be nice to know if it isgnmi
or sth else. But having the option of using a protocol other than gnmi might not happen too soon.
requested review from @istmabauc
- Resolved
The type within the
TransportOption
of the.proto
file could be removed aswell, right (see here)?
mentioned in issue #318
mentioned in commit b37a109f
Please register or sign in to reply