Refactoring

protocols/bgp/server/fsm_active.go

@@ -56,7 +56,7 @@ func (s *activeState) connectRetryTimerExpired() (state, string) {
 func (s *activeState) connectionSuccess(con net.Conn) (state, string) {
 	if s.fsm.peer.ttl != 0 {
 		SetTCPConnTTLSockopt(con, s.fsm.peer.ttl)
-	} else if s.fsm.peer.localASN != s.fsm.peer.peerASN {
+	} else if s.fsm.peer.isEBGP() {
 		SetTCPConnTTLSockopt(con, 1)
 	}
 

protocols/bgp/server/fsm_connect.go

@@ -39,7 +39,7 @@ func (s connectState) run() (state, string) {
 func (s *connectState) connectionSuccess(c net.Conn) (state, string) {
 	if s.fsm.peer.ttl != 0 {
 		SetTCPConnTTLSockopt(c, s.fsm.peer.ttl)
-	} else if s.fsm.peer.localASN != s.fsm.peer.peerASN {
+	} else if s.fsm.peer.isEBGP() {
 		SetTCPConnTTLSockopt(c, 1)
 	}
 

protocols/bgp/server/peer.go

@@ -404,3 +404,7 @@ func (p *peer) stop() {
 		fsm.eventCh <- ManualStop
 	}
 }
+
+func (p *peer) isEBGP() bool {
+	return p.localASN != p.peerASN
+}