Skip to content
Snippets Groups Projects
Commit 65889941 authored by Daniel Czerwonk's avatar Daniel Czerwonk
Browse files

addressed review comments

parent f7eed225
No related branches found
No related tags found
No related merge requests found
......@@ -172,8 +172,12 @@ func (b *BGPPath) Prepend(asn uint32, times uint16) {
return
}
if len(b.ASPath) == 0 {
b.insertNewASSequence()
}
first := b.ASPath[0]
if len(b.ASPath) == 0 || first.Type == packet.ASSet {
if first.Type == packet.ASSet {
b.insertNewASSequence()
}
......@@ -228,11 +232,8 @@ func (b *BGPPath) ComputeHash() string {
b.LargeCommunities,
b.PathIdentifier)
r := strings.NewReader(s)
h := sha256.New()
r.WriteTo(h)
return fmt.Sprintf("%x", h.Sum(nil))
return fmt.Sprintf("%x", h.Sum([]byte(s)))
}
// CommunitiesString returns the formated communities
......
......@@ -36,9 +36,9 @@ func TestComputeHash(t *testing.T) {
Source: 4,
}
assert.Equal(t, "45e238420552b88043edb8cb402034466b08d53b49f8e0fedc680747014ddeff", p.ComputeHash())
assert.Equal(t, "313030093130300931323320343536093009310966616c736509310934095b313233203435365d095b7b33203120327d5d0935e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855", p.ComputeHash())
p.LocalPref = 150
assert.NotEqual(t, "45e238420552b88043edb8cb402034466b08d53b49f8e0fedc680747014ddeff", p.ComputeHash())
assert.NotEqual(t, "313030093130300931323320343536093009310966616c736509310934095b313233203435365d095b7b33203120327d5d0935e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855", p.ComputeHash())
}
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment