Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Menu
Open sidebar
runcon
Plantuml Server
Commits
beb8c490
Commit
beb8c490
authored
Sep 13, 2013
by
maximesinclair
Browse files
[BUGFIX] Text/plain outputs always in unicode
parent
7d7aa411
Changes
6
Hide whitespace changes
Inline
Side-by-side
src/main/java/net/sourceforge/plantuml/servlet/AsciiServlet.java
View file @
beb8c490
...
...
@@ -44,7 +44,7 @@ public class AsciiServlet extends UmlDiagramService {
@Override
public
FileFormat
getOutputFormat
()
{
return
FileFormat
.
A
TXT
;
return
FileFormat
.
U
TXT
;
}
}
src/main/java/net/sourceforge/plantuml/servlet/DiagramResponse.java
View file @
beb8c490
...
...
@@ -24,11 +24,11 @@
package
net.sourceforge.plantuml.servlet
;
import
java.io.IOException
;
import
java.io.PrintWriter
;
import
java.util.Collections
;
import
java.util.HashMap
;
import
java.util.Map
;
import
javax.servlet.ServletOutputStream
;
import
javax.servlet.http.HttpServletResponse
;
import
net.sourceforge.plantuml.FileFormat
;
...
...
@@ -49,7 +49,7 @@ class DiagramResponse {
Map
<
FileFormat
,
String
>
map
=
new
HashMap
<
FileFormat
,
String
>();
map
.
put
(
FileFormat
.
PNG
,
"image/png"
);
map
.
put
(
FileFormat
.
SVG
,
"image/svg+xml"
);
map
.
put
(
FileFormat
.
A
TXT
,
"text/plain;charset=
ISO-8859-1
"
);
map
.
put
(
FileFormat
.
U
TXT
,
"text/plain;charset=
UTF-8
"
);
contentType
=
Collections
.
unmodifiableMap
(
map
);
}
...
...
@@ -76,7 +76,7 @@ class DiagramResponse {
SourceStringReader
reader
=
new
SourceStringReader
(
uml
);
String
map
=
reader
.
generateImage
(
new
NullOutputStream
(),
new
FileFormatOption
(
FileFormat
.
PNG
));
String
[]
mapLines
=
map
.
split
(
"[\\r\\n]"
);
ServletOutputStream
httpOut
=
response
.
get
OutputStream
();
PrintWriter
httpOut
=
response
.
get
Writer
();
for
(
int
i
=
2
;
(
i
+
1
)<
mapLines
.
length
;
i
++)
{
httpOut
.
print
(
mapLines
[
i
]);
}
...
...
src/main/java/net/sourceforge/plantuml/servlet/MapServlet.java
View file @
beb8c490
...
...
@@ -68,7 +68,7 @@ public class MapServlet extends HttpServlet {
}
public
FileFormat
getOutputFormat
()
{
return
FileFormat
.
A
TXT
;
return
FileFormat
.
U
TXT
;
}
}
src/test/java/net/sourceforge/plantuml/servlet/AllTests.java
View file @
beb8c490
...
...
@@ -14,6 +14,7 @@ public class AllTests extends TestSuite {
suite
.
addTestSuite
(
TestSVG
.
class
);
suite
.
addTestSuite
(
TestProxy
.
class
);
suite
.
addTestSuite
(
TestMap
.
class
);
suite
.
addTestSuite
(
TestCharset
.
class
);
// $JUnit-END$
return
suite
;
}
...
...
src/test/java/net/sourceforge/plantuml/servlet/TestAsciiArt.java
View file @
beb8c490
...
...
@@ -17,6 +17,7 @@ public class TestAsciiArt extends WebappTestCase {
// Analyze response
// Verifies the Content-Type header
assertEquals
(
"Response content type is not TEXT PLAIN"
,
"text/plain"
,
response
.
getContentType
());
assertEquals
(
"Response character set is not UTF-8"
,
"UTF-8"
,
response
.
getCharacterSet
());
// Get the content and verify its size
String
diagram
=
response
.
getText
();
int
diagramLen
=
diagram
.
length
();
...
...
src/test/java/net/sourceforge/plantuml/servlet/TestMap.java
View file @
beb8c490
...
...
@@ -19,7 +19,7 @@ public class TestMap extends WebappTestCase {
// Analyze response
// Verifies the Content-Type header
assertEquals
(
"Response content type is not TEXT PLAIN"
,
"text/plain"
,
response
.
getContentType
());
assertEquals
(
"Response character set is not
ISO-8859-1"
,
"ISO-8859-1
"
,
response
.
getCharacterSet
());
assertEquals
(
"Response character set is not
UTF-8"
,
"UTF-8
"
,
response
.
getCharacterSet
());
// Get the content, check its first characters and verify its size
String
diagram
=
response
.
getText
();
assertTrue
(
"Response content is not starting with <area"
,
diagram
.
startsWith
(
"<area"
));
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment