-
- Downloads
"README.md" did not exist on "2fffba7fe19690e038314d17a117d6b87979c89f"
cmd/compile: re-compile instantiated generic methods in linkshared mode
For G[T] that was seen and compiled in imported package, it is not added to typecheck.Target.Decls, prevent wasting compile time re-creating DUPOKS symbols. However, the linker do not support a type symbol referencing a method symbol across DSO boundary. That causes unreachable sym error when building under -linkshared mode. To fix it, always re-compile generic methods in linkshared mode. Fixes #58966 Change-Id: I894b417cfe8234ae1fe809cc975889345df22cef Reviewed-on: https://go-review.googlesource.com/c/go/+/477375 Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com> Reviewed-by:Cherry Mui <cherryyz@google.com> Reviewed-by:
Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
Showing
- misc/cgo/testshared/shared_test.go 6 additions, 1 deletionmisc/cgo/testshared/shared_test.go
- misc/cgo/testshared/testdata/issue58966/main.go 15 additions, 0 deletionsmisc/cgo/testshared/testdata/issue58966/main.go
- src/cmd/compile/internal/noder/unified.go 5 additions, 1 deletionsrc/cmd/compile/internal/noder/unified.go
Loading
Please register or sign in to comment