-
- Downloads
syscall: add CgroupFD support for ForkExec on Linux
Implement CLONE_INTO_CGROUP feature, allowing to put a child in a specified cgroup in a clean and simple way. Note that the feature only works for cgroup v2, and requires Linux kernel 5.7 or newer. Using the feature requires a new syscall, clone3. Currently this is the only reason to use clone3, but the code is structured in a way so that other cases may be easily added in the future. Add a test case. While at it, try to simplify the syscall calling code in forkAndExecInChild1, which became complicated over time because: 1. It was using either rawVforkSyscall or RawSyscall6 depending on whether CLONE_NEWUSER was set. 2. On Linux/s390, the first two arguments to clone(2) system call are swapped (which deserved a mention in Linux ABI hall of shame). It was worked around in rawVforkSyscall on s390, but had to be implemented via a switch/case when using RawSyscall6, making the code less clear. Let's - modify rawVforkSyscall to have two arguments (which is also required for clone3); - remove the arguments workaround from s390 asm, instead implementing arguments swap in the caller (which still looks ugly but at least it's done once and is clearly documented now); - use rawVforkSyscall for all cases (since it is essentially similar to RawSyscall6, except for having less parameters, not returning r2, and saving/restoring the return address before/after syscall on 386 and amd64). Updates #51246. Change-Id: Ifcd418ebead9257177338ffbcccd0bdecb94474e Reviewed-on: https://go-review.googlesource.com/c/go/+/417695 Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by:Michael Knyszek <mknyszek@google.com> Reviewed-by:
Ian Lance Taylor <iant@google.com> Run-TryBot: Ian Lance Taylor <iant@google.com> Run-TryBot: Kirill Kolyshkin <kolyshkin@gmail.com> TryBot-Result: Gopher Robot <gobot@golang.org>
Showing
- api/next/51246.txt 12 additions, 0 deletionsapi/next/51246.txt
- src/syscall/asm_linux_386.s 7 additions, 7 deletionssrc/syscall/asm_linux_386.s
- src/syscall/asm_linux_amd64.s 7 additions, 7 deletionssrc/syscall/asm_linux_amd64.s
- src/syscall/asm_linux_arm.s 7 additions, 7 deletionssrc/syscall/asm_linux_arm.s
- src/syscall/asm_linux_arm64.s 7 additions, 7 deletionssrc/syscall/asm_linux_arm64.s
- src/syscall/asm_linux_loong64.s 7 additions, 7 deletionssrc/syscall/asm_linux_loong64.s
- src/syscall/asm_linux_mips64x.s 7 additions, 7 deletionssrc/syscall/asm_linux_mips64x.s
- src/syscall/asm_linux_mipsx.s 7 additions, 7 deletionssrc/syscall/asm_linux_mipsx.s
- src/syscall/asm_linux_ppc64x.s 7 additions, 7 deletionssrc/syscall/asm_linux_ppc64x.s
- src/syscall/asm_linux_riscv64.s 7 additions, 7 deletionssrc/syscall/asm_linux_riscv64.s
- src/syscall/asm_linux_s390x.s 8 additions, 8 deletionssrc/syscall/asm_linux_s390x.s
- src/syscall/exec_linux.go 42 additions, 8 deletionssrc/syscall/exec_linux.go
- src/syscall/exec_linux_test.go 92 additions, 0 deletionssrc/syscall/exec_linux_test.go
- src/syscall/syscall_linux.go 1 addition, 0 deletionssrc/syscall/syscall_linux.go
- src/syscall/syscall_linux_386.go 1 addition, 2 deletionssrc/syscall/syscall_linux_386.go
- src/syscall/syscall_linux_amd64.go 1 addition, 2 deletionssrc/syscall/syscall_linux_amd64.go
- src/syscall/syscall_linux_arm.go 1 addition, 2 deletionssrc/syscall/syscall_linux_arm.go
- src/syscall/syscall_linux_arm64.go 1 addition, 2 deletionssrc/syscall/syscall_linux_arm64.go
- src/syscall/syscall_linux_loong64.go 1 addition, 2 deletionssrc/syscall/syscall_linux_loong64.go
- src/syscall/syscall_linux_mips64x.go 1 addition, 2 deletionssrc/syscall/syscall_linux_mips64x.go
Please register or sign in to comment