Skip to content
Snippets Groups Projects
  • Jeremy Quirke's avatar
    c2c4a32f
    cmd/link: remove objIdx structure · c2c4a32f
    Jeremy Quirke authored
    This indirection appears to be unnecessary for linking or linker debugging, and therefore hinders readability.
    
    Since all *oReaders are added to loader.objs *only* via the Preload -> addObj path, before any symbols are examined, there is no possible way the "i" member of this structure is still useful; and is likely a remnant of an earlier design.
    
    Change-Id: Icd880f40bf3299bf1aa0a14cf217268e49ee90c5
    GitHub-Last-Rev: dd2d512cbe99a551585fc9f895eca28a5bfde21b
    GitHub-Pull-Request: golang/go#57460
    Reviewed-on: https://go-review.googlesource.com/c/go/+/459456
    
    
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: default avatarqiulaidongfeng <2645477756@qq.com>
    Reviewed-by: default avatarThan McIntosh <thanm@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: default avatarCherry Mui <cherryyz@google.com>
    Auto-Submit: Ian Lance Taylor <iant@golang.org>
    c2c4a32f
    History
    cmd/link: remove objIdx structure
    Jeremy Quirke authored
    This indirection appears to be unnecessary for linking or linker debugging, and therefore hinders readability.
    
    Since all *oReaders are added to loader.objs *only* via the Preload -> addObj path, before any symbols are examined, there is no possible way the "i" member of this structure is still useful; and is likely a remnant of an earlier design.
    
    Change-Id: Icd880f40bf3299bf1aa0a14cf217268e49ee90c5
    GitHub-Last-Rev: dd2d512cbe99a551585fc9f895eca28a5bfde21b
    GitHub-Pull-Request: golang/go#57460
    Reviewed-on: https://go-review.googlesource.com/c/go/+/459456
    
    
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: default avatarqiulaidongfeng <2645477756@qq.com>
    Reviewed-by: default avatarThan McIntosh <thanm@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: default avatarCherry Mui <cherryyz@google.com>
    Auto-Submit: Ian Lance Taylor <iant@golang.org>
Code owners
Assign users and groups as approvers for specific file changes. Learn more.