Skip to content
Snippets Groups Projects
  • Filippo Valsorda's avatar
    c96159c2
    crypto/x509: cleanup signature generation · c96159c2
    Filippo Valsorda authored
    Centralizing some repetitive code, which would have prevented #45990.
    
    This also fixes the deprecated Certificate.CreateCRL for RSA-PSS, not
    that anyone cared, probably.
    
    This has two other minor observable behavior changes: MD2 is now treated
    as a completely unknown algorithm (why did we even have that!? removing
    lets us treat hash == 0 as always meaning no prehash); and we now do the
    signature verification self-check for all signing operations.
    
    Change-Id: I3b34fe0c3b6eb6181d2145b0704834225cd45a27
    Reviewed-on: https://go-review.googlesource.com/c/go/+/586015
    
    
    Reviewed-by: default avatarDmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: default avatarRoland Shoemaker <roland@golang.org>
    Auto-Submit: Filippo Valsorda <filippo@golang.org>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    c96159c2
    History
    crypto/x509: cleanup signature generation
    Filippo Valsorda authored
    Centralizing some repetitive code, which would have prevented #45990.
    
    This also fixes the deprecated Certificate.CreateCRL for RSA-PSS, not
    that anyone cared, probably.
    
    This has two other minor observable behavior changes: MD2 is now treated
    as a completely unknown algorithm (why did we even have that!? removing
    lets us treat hash == 0 as always meaning no prehash); and we now do the
    signature verification self-check for all signing operations.
    
    Change-Id: I3b34fe0c3b6eb6181d2145b0704834225cd45a27
    Reviewed-on: https://go-review.googlesource.com/c/go/+/586015
    
    
    Reviewed-by: default avatarDmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: default avatarRoland Shoemaker <roland@golang.org>
    Auto-Submit: Filippo Valsorda <filippo@golang.org>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Code owners
Assign users and groups as approvers for specific file changes. Learn more.