Skip to content
Snippets Groups Projects
  • Than McIntosh's avatar
    9a5468ed
    [dev.link] cmd/link: fix some bugs in loader · 9a5468ed
    Than McIntosh authored
    This patch fixes a couple of bugs introduced in CL 210778 and CL 207606:
    
    - apply the same version selection scheme in loader.CreateExtSym that
      we're currently using for loader.Create (since the two functions
      will be used in the same way by the host object loader)
    
    - add code to the loader's NewLoader function to create initial map
      values for some of the map-based symbol attributes (somewhere along
      the line the code to do this seems to have gotten lost, so this
      patch adds it back).
    
    - fix a coding error in growAttrBitmaps (wrong bitmap passed to
      append when extending attrOnList)
    
    Change-Id: Ie0c8c6876428bb21d788c19a7a2db945ac649fac
    Reviewed-on: https://go-review.googlesource.com/c/go/+/212097
    
    
    Reviewed-by: default avatarJeremy Faller <jeremy@golang.org>
    Reviewed-by: default avatarCherry Zhang <cherryyz@google.com>
    9a5468ed
    History
    [dev.link] cmd/link: fix some bugs in loader
    Than McIntosh authored
    This patch fixes a couple of bugs introduced in CL 210778 and CL 207606:
    
    - apply the same version selection scheme in loader.CreateExtSym that
      we're currently using for loader.Create (since the two functions
      will be used in the same way by the host object loader)
    
    - add code to the loader's NewLoader function to create initial map
      values for some of the map-based symbol attributes (somewhere along
      the line the code to do this seems to have gotten lost, so this
      patch adds it back).
    
    - fix a coding error in growAttrBitmaps (wrong bitmap passed to
      append when extending attrOnList)
    
    Change-Id: Ie0c8c6876428bb21d788c19a7a2db945ac649fac
    Reviewed-on: https://go-review.googlesource.com/c/go/+/212097
    
    
    Reviewed-by: default avatarJeremy Faller <jeremy@golang.org>
    Reviewed-by: default avatarCherry Zhang <cherryyz@google.com>
Code owners
Assign users and groups as approvers for specific file changes. Learn more.