Skip to content
Snippets Groups Projects
  • Russ Cox's avatar
    26b66fd6
    [dev.regabi] cmd/compile: introduce cmd/compile/internal/base [generated] · 26b66fd6
    Russ Cox authored
    Move Flag, Debug, Ctxt, Exit, and error messages to
    new package cmd/compile/internal/base.
    
    These are the core functionality that everything in gc uses
    and which otherwise prevent splitting any other code
    out of gc into different packages.
    
    A minor milestone: the compiler source code
    no longer contains the string "yy".
    
    [git-generate]
    cd src/cmd/compile/internal/gc
    rf '
            mv atExit AtExit
            mv Ctxt atExitFuncs AtExit Exit base.go
    
            mv lineno Pos
            mv linestr FmtPos
            mv flusherrors FlushErrors
            mv yyerror Errorf
            mv yyerrorl ErrorfAt
            mv yyerrorv ErrorfVers
            mv noder.yyerrorpos noder.errorAt
            mv Warnl WarnfAt
            mv errorexit ErrorExit
    
            mv base.go debug.go flag.go print.go cmd/compile/internal/base
    '
    
    : # update comments
    sed -i '' 's/yyerrorl/ErrorfAt/g; s/yyerror/Errorf/g' *.go
    
    : # bootstrap.go is not built by default so invisible to rf
    sed -i '' 's/Fatalf/base.Fatalf/' bootstrap.go
    goimports -w bootstrap.go
    
    : # update cmd/dist to add internal/base
    cd ../../../dist
    sed -i '' '/internal.amd64/a\
    	"cmd/compile/internal/base",
    ' buildtool.go
    gofmt -w buildtool.go
    
    Change-Id: I59903c7084222d6eaee38823fd222159ba24a31a
    Reviewed-on: https://go-review.googlesource.com/c/go/+/272250
    
    
    Trust: Russ Cox <rsc@golang.org>
    Reviewed-by: default avatarMatthew Dempsky <mdempsky@google.com>
    26b66fd6
    History
    [dev.regabi] cmd/compile: introduce cmd/compile/internal/base [generated]
    Russ Cox authored
    Move Flag, Debug, Ctxt, Exit, and error messages to
    new package cmd/compile/internal/base.
    
    These are the core functionality that everything in gc uses
    and which otherwise prevent splitting any other code
    out of gc into different packages.
    
    A minor milestone: the compiler source code
    no longer contains the string "yy".
    
    [git-generate]
    cd src/cmd/compile/internal/gc
    rf '
            mv atExit AtExit
            mv Ctxt atExitFuncs AtExit Exit base.go
    
            mv lineno Pos
            mv linestr FmtPos
            mv flusherrors FlushErrors
            mv yyerror Errorf
            mv yyerrorl ErrorfAt
            mv yyerrorv ErrorfVers
            mv noder.yyerrorpos noder.errorAt
            mv Warnl WarnfAt
            mv errorexit ErrorExit
    
            mv base.go debug.go flag.go print.go cmd/compile/internal/base
    '
    
    : # update comments
    sed -i '' 's/yyerrorl/ErrorfAt/g; s/yyerror/Errorf/g' *.go
    
    : # bootstrap.go is not built by default so invisible to rf
    sed -i '' 's/Fatalf/base.Fatalf/' bootstrap.go
    goimports -w bootstrap.go
    
    : # update cmd/dist to add internal/base
    cd ../../../dist
    sed -i '' '/internal.amd64/a\
    	"cmd/compile/internal/base",
    ' buildtool.go
    gofmt -w buildtool.go
    
    Change-Id: I59903c7084222d6eaee38823fd222159ba24a31a
    Reviewed-on: https://go-review.googlesource.com/c/go/+/272250
    
    
    Trust: Russ Cox <rsc@golang.org>
    Reviewed-by: default avatarMatthew Dempsky <mdempsky@google.com>
Code owners
Assign users and groups as approvers for specific file changes. Learn more.