diff --git a/.golangci.yml b/.golangci.yml index 7ca89f0ca561d470c8e31acdbd4591b35215a9cb..c658d914f7f592f1695995d0c9ed022323fdb819 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -17,7 +17,6 @@ linters: # TODO: fix me - unparam - - goimports - golint - whitespace - goconst diff --git a/cmd/dex/config_test.go b/cmd/dex/config_test.go index d7875ad151448c33e90ded40e88cebc0ea5bb185..87f1a5787eb34147d39e216f903ee9bd80320de3 100644 --- a/cmd/dex/config_test.go +++ b/cmd/dex/config_test.go @@ -1,7 +1,6 @@ package main import ( - "github.com/dexidp/dex/server" "testing" "github.com/ghodss/yaml" @@ -9,6 +8,7 @@ import ( "github.com/dexidp/dex/connector/mock" "github.com/dexidp/dex/connector/oidc" + "github.com/dexidp/dex/server" "github.com/dexidp/dex/storage" "github.com/dexidp/dex/storage/sql" ) diff --git a/connector/google/google.go b/connector/google/google.go index 7561ca4d3b35bc1d08f544f108914760099955a6..37b6dc153a1cde803e9831fc5cc161f1bb8615c1 100644 --- a/connector/google/google.go +++ b/connector/google/google.go @@ -11,12 +11,12 @@ import ( "github.com/coreos/go-oidc" "golang.org/x/oauth2" + "golang.org/x/oauth2/google" + admin "google.golang.org/api/admin/directory/v1" "github.com/dexidp/dex/connector" pkg_groups "github.com/dexidp/dex/pkg/groups" "github.com/dexidp/dex/pkg/log" - "golang.org/x/oauth2/google" - admin "google.golang.org/api/admin/directory/v1" ) const ( diff --git a/connector/oidc/oidc_test.go b/connector/oidc/oidc_test.go index f766a875c69050012e06ca069b3f77afc37b02fa..22b035c173294b11905f11b55de4f9ec30b485cd 100644 --- a/connector/oidc/oidc_test.go +++ b/connector/oidc/oidc_test.go @@ -16,9 +16,10 @@ import ( "testing" "time" - "github.com/dexidp/dex/connector" "github.com/sirupsen/logrus" "gopkg.in/square/go-jose.v2" + + "github.com/dexidp/dex/connector" ) func TestKnownBrokenAuthHeaderProvider(t *testing.T) { diff --git a/connector/saml/saml.go b/connector/saml/saml.go index f4e52a69372d3d584ab6bdde9284388edb2f0f44..70ab413c771c1b63f6cc20ee0585cb3454355bd6 100644 --- a/connector/saml/saml.go +++ b/connector/saml/saml.go @@ -14,11 +14,12 @@ import ( "time" "github.com/beevik/etree" + dsig "github.com/russellhaering/goxmldsig" + "github.com/russellhaering/goxmldsig/etreeutils" + "github.com/dexidp/dex/connector" "github.com/dexidp/dex/pkg/groups" "github.com/dexidp/dex/pkg/log" - dsig "github.com/russellhaering/goxmldsig" - "github.com/russellhaering/goxmldsig/etreeutils" ) // nolint diff --git a/server/server.go b/server/server.go index fa86033079782ba1d4b8f1b7a20b7e91e0729e4f..4dc7337d033e0765d9586647d4e56aff40d9995d 100644 --- a/server/server.go +++ b/server/server.go @@ -14,6 +14,10 @@ import ( "sync/atomic" "time" + "github.com/felixge/httpsnoop" + "github.com/gorilla/handlers" + "github.com/gorilla/mux" + "github.com/prometheus/client_golang/prometheus" "golang.org/x/crypto/bcrypt" "github.com/dexidp/dex/connector" @@ -31,10 +35,6 @@ import ( "github.com/dexidp/dex/connector/saml" "github.com/dexidp/dex/pkg/log" "github.com/dexidp/dex/storage" - "github.com/felixge/httpsnoop" - "github.com/gorilla/handlers" - "github.com/gorilla/mux" - "github.com/prometheus/client_golang/prometheus" ) // LocalConnector is the local passwordDB connector which is an internal