From 1f2771b57e3e211a39ae172b397cd6fce67d7d90 Mon Sep 17 00:00:00 2001
From: "m.nabokikh" <maksim.nabokikh@flant.com>
Date: Sat, 20 Feb 2021 12:55:52 +0400
Subject: [PATCH] fix: do not run LDAP tests locally by default
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
---
.github/workflows/ci.yaml | 1 +
connector/ldap/ldap_test.go | 4 ++++
2 files changed, 5 insertions(+)
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 0ea01b98..3fa95864 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -71,6 +71,7 @@ jobs:
DEX_POSTGRES_HOST: localhost
DEX_POSTGRES_PORT: ${{ job.services.postgres.ports[5432] }}
DEX_ETCD_ENDPOINTS: http://localhost:${{ job.services.etcd.ports[2379] }}
+ DEX_LDAP_TESTS: yes
DEX_LDAP_HOST: localhost
DEX_LDAP_PORT: 389
DEX_LDAP_TLS_PORT: 636
diff --git a/connector/ldap/ldap_test.go b/connector/ldap/ldap_test.go
index 61383924..8c1eec4b 100644
--- a/connector/ldap/ldap_test.go
+++ b/connector/ldap/ldap_test.go
@@ -526,6 +526,10 @@ func getenv(key, defaultVal string) string {
// The tests require LDAP to be runnning.
// You can use the provided docker-compose file to setup an LDAP server.
func runTests(t *testing.T, connMethod connectionMethod, config *Config, tests []subtest) {
+ if os.Getenv("DEX_LDAP_TESTS") == "" {
+ t.Skip("Specify not-empty DEX_LDAP_TESTS env variable to enable LDAP tests")
+ }
+
// Shallow copy.
c := *config
--
GitLab