goSDN merge requestshttps://code.fbi.h-da.de/danet/gosdn/-/merge_requests2024-03-06T13:28:47Zhttps://code.fbi.h-da.de/danet/gosdn/-/merge_requests/712Draft: Resolve "Lint shadowing of global variables"2024-03-06T13:28:47ZNeil-Jocelyn ScharkDraft: Resolve "Lint shadowing of global variables"<!--- Provide a general summary of your changes in the Title above -->
## Description
<!--- Describe your changes in detail -->
## Related Issue
<!--- This project only accepts merge requests related to open issues -->
<!--- If suggest...<!--- Provide a general summary of your changes in the Title above -->
## Description
<!--- Describe your changes in detail -->
## Related Issue
<!--- This project only accepts merge requests related to open issues -->
<!--- If suggesting a new feature or change, please discuss it in an issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->
<!--- Please link to the issue here: -->
## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
## How Has This Been Tested?
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran to -->
<!--- see how your change affects other areas of the code, etc. -->
## Screenshots (if appropriate):
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [ ] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have read the **CONTRIBUTING** document.
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
Related to #351Neil-Jocelyn ScharkNeil-Jocelyn Scharkhttps://code.fbi.h-da.de/danet/gosdn/-/merge_requests/557Draft: Refactor nucleus to remove hard dependencies on structs2023-10-09T06:11:41ZAndre SterbaDraft: Refactor nucleus to remove hard dependencies on structs## Description
The idea is to add an aditional layer around the `core models` (like networkElement and others).
This will enable more flexibility in the `nucleus` package and remove problems with circular dependencies and the question ...## Description
The idea is to add an aditional layer around the `core models` (like networkElement and others).
This will enable more flexibility in the `nucleus` package and remove problems with circular dependencies and the question `where to place interfaces for our services, stores, ...?`.
This should also remove the `interfaces` folder that is filled with interfaces and structs.
After this we can also think about moving movings like `rbac` and `topology` back in the nucleus instead of in own packages and shared functionalitiy (like stores and services).
This will roughly follow the ideas of ports&adapters, hexagonal architecture and/or onion architecture. (I like this [article](https://www.happycoders.eu/de/software-craftsmanship/hexagonale-architektur/) about it)
## Related Issue
## Motivation and Context
## How Has This Been Tested?
## Screenshots (if appropriate):
## Types of changes
* [ ] Bug fix (non-breaking change which fixes an issue)
* [ ] New feature (non-breaking change which adds functionality)
* [ ] Breaking change (fix or feature that would cause existing functionality to change)
## Checklist:
* [ ] My code follows the code style of this project.
* [ ] My change requires a change to the documentation.
* [ ] I have updated the documentation accordingly.
* [ ] I have read the **CONTRIBUTING** document.
* [ ] I have added tests to cover my changes.
* [ ] All new and existing tests passed.