goSDN issues
https://code.fbi.h-da.de/danet/gosdn/-/issues
2024-03-13T09:07:46Z
https://code.fbi.h-da.de/danet/gosdn/-/issues/359
Update gRPC abstraction API with missing calls and refactoring
2024-03-13T09:07:46Z
Fabian Seidl
Update gRPC abstraction API with missing calls and refactoring
<!--- Provide a general summary of the issue in the Title above -->
## Description
<!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug -->
## Expected Behavior
<!--- Tell us what should h...
<!--- Provide a general summary of the issue in the Title above -->
## Description
<!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug -->
## Expected Behavior
<!--- Tell us what should happen -->
## Actual Behavior
<!--- Tell us what happens instead -->
## Possible Fix
<!--- Not obligatory, but suggest a fix or reason for the bug -->
## Steps to Reproduce
<!--- Provide a link to a live example, or an unambiguous set of steps to -->
<!--- reproduce this bug. Include code to reproduce, if relevant -->
1.
2.
3.
4.
## Context
<!--- How has this bug affected you? What were you trying to accomplish? -->
## Your Environment
<!--- Include as many relevant details about the environment you experienced the bug in -->
* Version used:
* Environment name and version (e.g. go v1.16.3 on FreeBSD 13.0-current):
* Server type and version:
* Operating System and version:
https://code.fbi.h-da.de/danet/gosdn/-/issues/358
Mongo-Express within clab environments returns with an error
2024-03-14T14:24:26Z
Malte Bauch
Mongo-Express within clab environments returns with an error
<!--- Provide a general summary of the issue in the Title above -->
Accessing the mongo-express URL after starting a containerlab returns in an error message:
`Turn on admin in config.js to view server stats!`
## Description
<!--- Prov...
<!--- Provide a general summary of the issue in the Title above -->
Accessing the mongo-express URL after starting a containerlab returns in an error message:
`Turn on admin in config.js to view server stats!`
## Description
<!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug -->
See: https://github.com/mongo-express/mongo-express/issues/809
## Expected Behavior
<!--- Tell us what should happen -->
It should be possible to access database information.
## Actual Behavior
<!--- Tell us what happens instead -->
No database information is shown, instead an error is thrown.
## Possible Fix
<!--- Not obligatory, but suggest a fix or reason for the bug -->
Update version and set the correct environment variables.
## Steps to Reproduce
<!--- Provide a link to a live example, or an unambiguous set of steps to -->
<!--- reproduce this bug. Include code to reproduce, if relevant -->
1. Start one of the containerlabs
2. Access `localhost:8081
3. Error appears
## Context
<!--- How has this bug affected you? What were you trying to accomplish? -->
## Your Environment
<!--- Include as many relevant details about the environment you experienced the bug in -->
* Version used:
* Environment name and version (e.g. go v1.16.3 on FreeBSD 13.0-current):
* Server type and version:
* Operating System and version:
Malte Bauch
Malte Bauch
https://code.fbi.h-da.de/danet/gosdn/-/issues/357
Change the way user credentials for authz are provided to not be in context
2024-03-19T14:09:03Z
Fabian Seidl
Change the way user credentials for authz are provided to not be in context
<!--- Provide a general summary of the issue in the Title above -->
## Description
<!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug -->
Currently, the credentials to authenticate/autho...
<!--- Provide a general summary of the issue in the Title above -->
## Description
<!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug -->
Currently, the credentials to authenticate/authorize are send in the context. This works well for go but not if the communication via gRPC/REST is done from an application written in another language. These apps would not be able to get authorized to do anything in any way. Therefore, the credentials should be provided in another way.
Ideas welcome!
This change will introduce lots of changes in other areas, to be more precise, possibly for our own applications, the tests, the gRPC API abstraction thing and gosdnc. So, implementing a new way of providing the credentials will lead to many small adjustments. Might take some time to find them all.
https://code.fbi.h-da.de/danet/gosdn/-/issues/356
Credentials returned after registering an app are hard coded, which causes pr...
2024-02-22T10:40:33Z
Fabian Seidl
Credentials returned after registering an app are hard coded, which causes problems if RabbitMQ is not hosted on localhost
<!--- Provide a general summary of the issue in the Title above -->
## Description
<!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug -->
The method controller/app/Service.go/createNewApp...
<!--- Provide a general summary of the issue in the Title above -->
## Description
<!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug -->
The method controller/app/Service.go/createNewApp always returns "amqp://guest:guest@127.0.0.1:5672" as credentials for an App registering to the Event System. This needs to be fixed.
## Expected Behavior
<!--- Tell us what should happen -->
Method returns correct crededentials dynamically.
## Actual Behavior
<!--- Tell us what happens instead -->
Hard coded string that worked until it didn't :shrug:
## Possible Fix
Use data read from the config file and stored in global vars in config package, e.g. config.AMQPHost.
https://code.fbi.h-da.de/danet/gosdn/-/issues/355
Missing plugin information if requesting a network element
2024-02-22T10:41:10Z
Malte Bauch
Missing plugin information if requesting a network element
<!--- Provide a general summary of the issue in the Title above -->
## Description
<!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug -->
## Expected Behavior
<!--- Tell us what should h...
<!--- Provide a general summary of the issue in the Title above -->
## Description
<!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug -->
## Expected Behavior
<!--- Tell us what should happen -->
## Actual Behavior
<!--- Tell us what happens instead -->
## Possible Fix
<!--- Not obligatory, but suggest a fix or reason for the bug -->
## Steps to Reproduce
<!--- Provide a link to a live example, or an unambiguous set of steps to -->
<!--- reproduce this bug. Include code to reproduce, if relevant -->
1.
2.
3.
4.
## Context
<!--- How has this bug affected you? What were you trying to accomplish? -->
## Your Environment
<!--- Include as many relevant details about the environment you experienced the bug in -->
* Version used:
* Environment name and version (e.g. go v1.16.3 on FreeBSD 13.0-current):
* Server type and version:
* Operating System and version:
https://code.fbi.h-da.de/danet/gosdn/-/issues/354
Fix "Config file not found and was unable to create" on new gosdn repo enviro...
2024-02-09T10:22:22Z
Katharina Renk
Fix "Config file not found and was unable to create" on new gosdn repo environment
If the gosdn repository is freshly cloned and the CLI is used, following error message appears: <br>
ERRO[0005] Config file not found and was unable to create, error: open ./config/.gosdnc.toml: permission denied <br>
To fix this, the pe...
If the gosdn repository is freshly cloned and the CLI is used, following error message appears: <br>
ERRO[0005] Config file not found and was unable to create, error: open ./config/.gosdnc.toml: permission denied <br>
To fix this, the permissions have to be (slightly) changed from 0600 to 0700 in gosdn/cli/cmd/root.go.
Katharina Renk
Katharina Renk
https://code.fbi.h-da.de/danet/gosdn/-/issues/353
Update go version in packer and vagrant VMs
2024-02-09T10:21:59Z
Katharina Renk
Update go version in packer and vagrant VMs
<!--- Provide a general summary of the issue in the Title above -->
## Description
<!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug -->
## Expected Behavior
<!--- Tell us what should h...
<!--- Provide a general summary of the issue in the Title above -->
## Description
<!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug -->
## Expected Behavior
<!--- Tell us what should happen -->
## Actual Behavior
<!--- Tell us what happens instead -->
## Possible Fix
<!--- Not obligatory, but suggest a fix or reason for the bug -->
## Steps to Reproduce
<!--- Provide a link to a live example, or an unambiguous set of steps to -->
<!--- reproduce this bug. Include code to reproduce, if relevant -->
1.
2.
3.
4.
## Context
<!--- How has this bug affected you? What were you trying to accomplish? -->
## Your Environment
<!--- Include as many relevant details about the environment you experienced the bug in -->
* Version used:
* Environment name and version (e.g. go v1.16.3 on FreeBSD 13.0-current):
* Server type and version:
* Operating System and version:
Katharina Renk
Katharina Renk
https://code.fbi.h-da.de/danet/gosdn/-/issues/352
Fix containerlab image for Lab01
2024-01-30T12:10:33Z
Katharina Renk
Fix containerlab image for Lab01
<!--- Provide a general summary of the issue in the Title above -->
## Description
<!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug -->
## Expected Behavior
<!--- Tell us what should h...
<!--- Provide a general summary of the issue in the Title above -->
## Description
<!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug -->
## Expected Behavior
<!--- Tell us what should happen -->
## Actual Behavior
<!--- Tell us what happens instead -->
## Possible Fix
<!--- Not obligatory, but suggest a fix or reason for the bug -->
## Steps to Reproduce
<!--- Provide a link to a live example, or an unambiguous set of steps to -->
<!--- reproduce this bug. Include code to reproduce, if relevant -->
1.
2.
3.
4.
## Context
<!--- How has this bug affected you? What were you trying to accomplish? -->
## Your Environment
<!--- Include as many relevant details about the environment you experienced the bug in -->
* Version used:
* Environment name and version (e.g. go v1.16.3 on FreeBSD 13.0-current):
* Server type and version:
* Operating System and version:
Katharina Renk
Katharina Renk
https://code.fbi.h-da.de/danet/gosdn/-/issues/351
Link shadowing of global variables
2024-01-19T14:38:17Z
Neil-Jocelyn Schark
Link shadowing of global variables
<!--- Provide a general summary of the issue in the Title above -->
## Description
<!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug -->
## Expected Behavior
<!--- Tell us what should h...
<!--- Provide a general summary of the issue in the Title above -->
## Description
<!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug -->
## Expected Behavior
<!--- Tell us what should happen -->
## Actual Behavior
<!--- Tell us what happens instead -->
## Possible Fix
<!--- Not obligatory, but suggest a fix or reason for the bug -->
## Steps to Reproduce
<!--- Provide a link to a live example, or an unambiguous set of steps to -->
<!--- reproduce this bug. Include code to reproduce, if relevant -->
1.
2.
3.
4.
## Context
<!--- How has this bug affected you? What were you trying to accomplish? -->
## Your Environment
<!--- Include as many relevant details about the environment you experienced the bug in -->
* Version used:
* Environment name and version (e.g. go v1.16.3 on FreeBSD 13.0-current):
* Server type and version:
* Operating System and version:
Neil-Jocelyn Schark
Neil-Jocelyn Schark
https://code.fbi.h-da.de/danet/gosdn/-/issues/350
Applying a SDN configuration should also update the internal configuration of...
2024-01-12T15:55:17Z
Malte Bauch
Applying a SDN configuration should also update the internal configuration of managed network elements
<!--- Provide a general summary of the issue in the Title above -->
The `ApplySDNConfig` function for integration tests only updates the configuration within the controller itself. If there is also a network element (e.g., a gnmi-target)...
<!--- Provide a general summary of the issue in the Title above -->
The `ApplySDNConfig` function for integration tests only updates the configuration within the controller itself. If there is also a network element (e.g., a gnmi-target) involved the configuration of that device stays untouched. In general it would be good if applying a SDN configuration would also mean that the available configuration of a network element is pushed down to that specific network element as well.
## Description
<!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug -->
## Expected Behavior
<!--- Tell us what should happen -->
Also update the internal configuration of managed network elements.
## Actual Behavior
<!--- Tell us what happens instead -->
Only the configuration within the controller is applied.
## Possible Fix
<!--- Not obligatory, but suggest a fix or reason for the bug -->
Extend `ImportSDNConfig` method of the configurationmanagement service to also set the root path of each device within a SDN config to the related network elements config.
## Steps to Reproduce
<!--- Provide a link to a live example, or an unambiguous set of steps to -->
<!--- reproduce this bug. Include code to reproduce, if relevant -->
1.
2.
3.
4.
## Context
<!--- How has this bug affected you? What were you trying to accomplish? -->
## Your Environment
<!--- Include as many relevant details about the environment you experienced the bug in -->
* Version used:
* Environment name and version (e.g. go v1.16.3 on FreeBSD 13.0-current):
* Server type and version:
* Operating System and version:
https://code.fbi.h-da.de/danet/gosdn/-/issues/349
Integration test for Lab01
2024-03-06T14:16:16Z
Katharina Renk
Integration test for Lab01
<!--- Provide a general summary of the issue in the Title above -->
## Description
<!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug -->
## Expected Behavior
<!--- Tell us what should h...
<!--- Provide a general summary of the issue in the Title above -->
## Description
<!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug -->
## Expected Behavior
<!--- Tell us what should happen -->
## Actual Behavior
<!--- Tell us what happens instead -->
## Possible Fix
<!--- Not obligatory, but suggest a fix or reason for the bug -->
## Steps to Reproduce
<!--- Provide a link to a live example, or an unambiguous set of steps to -->
<!--- reproduce this bug. Include code to reproduce, if relevant -->
1.
2.
3.
4.
## Context
<!--- How has this bug affected you? What were you trying to accomplish? -->
## Your Environment
<!--- Include as many relevant details about the environment you experienced the bug in -->
* Version used:
* Environment name and version (e.g. go v1.16.3 on FreeBSD 13.0-current):
* Server type and version:
* Operating System and version:
Katharina Renk
Katharina Renk
https://code.fbi.h-da.de/danet/gosdn/-/issues/348
Integration test for Lab00
2024-01-11T15:19:24Z
Malte Bauch
Integration test for Lab00
<!--- Provide a general summary of the issue in the Title above -->
Add a integration test for [Lab00](https://code.fbi.h-da.de/danet/gosdn/-/wikis/Labs/Lab00)
For each step within the lab the functionality of the methods in charge shou...
<!--- Provide a general summary of the issue in the Title above -->
Add a integration test for [Lab00](https://code.fbi.h-da.de/danet/gosdn/-/wikis/Labs/Lab00)
For each step within the lab the functionality of the methods in charge should be tested.
## Description
<!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug -->
## Expected Behavior
<!--- Tell us what should happen -->
## Actual Behavior
<!--- Tell us what happens instead -->
## Possible Fix
<!--- Not obligatory, but suggest a fix or reason for the bug -->
## Steps to Reproduce
<!--- Provide a link to a live example, or an unambiguous set of steps to -->
<!--- reproduce this bug. Include code to reproduce, if relevant -->
1.
2.
3.
4.
## Context
<!--- How has this bug affected you? What were you trying to accomplish? -->
## Your Environment
<!--- Include as many relevant details about the environment you experienced the bug in -->
* Version used:
* Environment name and version (e.g. go v1.16.3 on FreeBSD 13.0-current):
* Server type and version:
* Operating System and version:
Malte Bauch
Malte Bauch
https://code.fbi.h-da.de/danet/gosdn/-/issues/347
Implement integration tests for applications
2024-01-15T14:02:47Z
Fabian Seidl
Implement integration tests for applications
<!--- Provide a general summary of the issue in the Title above -->
## Description
<!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug -->
## Expected Behavior
<!--- Tell us what should h...
<!--- Provide a general summary of the issue in the Title above -->
## Description
<!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug -->
## Expected Behavior
<!--- Tell us what should happen -->
## Actual Behavior
<!--- Tell us what happens instead -->
## Possible Fix
<!--- Not obligatory, but suggest a fix or reason for the bug -->
## Steps to Reproduce
<!--- Provide a link to a live example, or an unambiguous set of steps to -->
<!--- reproduce this bug. Include code to reproduce, if relevant -->
1.
2.
3.
4.
## Context
<!--- How has this bug affected you? What were you trying to accomplish? -->
## Your Environment
<!--- Include as many relevant details about the environment you experienced the bug in -->
* Version used:
* Environment name and version (e.g. go v1.16.3 on FreeBSD 13.0-current):
* Server type and version:
* Operating System and version:
https://code.fbi.h-da.de/danet/gosdn/-/issues/346
Discuss future of topology
2024-01-22T09:15:34Z
Neil-Jocelyn Schark
Discuss future of topology
Currently the topology implementation has at least two major bugs. As we currently don't really use it anyway and the general implementation was very specific for a singular problem, we need to discuss the future of the topology. We will...
Currently the topology implementation has at least two major bugs. As we currently don't really use it anyway and the general implementation was very specific for a singular problem, we need to discuss the future of the topology. We will need one, but the path forward is not clear. We could fix the current implementation and potentially add more features to it or think of a new one.
Neil-Jocelyn Schark
Neil-Jocelyn Schark
https://code.fbi.h-da.de/danet/gosdn/-/issues/345
AddLink crashes goSDN when Link without correct port config is send.
2024-01-11T15:21:05Z
Neil-Jocelyn Schark
AddLink crashes goSDN when Link without correct port config is send.
A Link contains Ports which contain a Configuration. If it is send without one, goSDN crashes hard.
The AddLink endpoint has validation, but the validation seems to be incorrect/broken/not good enough to catch this.
A Link contains Ports which contain a Configuration. If it is send without one, goSDN crashes hard.
The AddLink endpoint has validation, but the validation seems to be incorrect/broken/not good enough to catch this.
https://code.fbi.h-da.de/danet/gosdn/-/issues/344
Discuss and implement integration tests for permission tests network elements
2023-12-15T14:07:18Z
Fabian Seidl
Discuss and implement integration tests for permission tests network elements
<!--- Provide a general summary of the issue in the Title above -->
## Description
<!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug -->
See this dicussion: https://code.fbi.h-da.de/dane...
<!--- Provide a general summary of the issue in the Title above -->
## Description
<!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug -->
See this dicussion: https://code.fbi.h-da.de/danet/gosdn/-/merge_requests/652#note_367580
for further information.
https://code.fbi.h-da.de/danet/gosdn/-/issues/343
Fix typo in nothbound api
2023-12-15T13:35:00Z
Neil-Jocelyn Schark
Fix typo in nothbound api
The proto definition has a typo.
```
message GetTopologyResponse {
int64 timestamp = 1;
Topology toplogy = 2;
}
```
It should be `topology`. This must be fixed on several instances.
The proto definition has a typo.
```
message GetTopologyResponse {
int64 timestamp = 1;
Topology toplogy = 2;
}
```
It should be `topology`. This must be fixed on several instances.
Neil-Jocelyn Schark
Neil-Jocelyn Schark
https://code.fbi.h-da.de/danet/gosdn/-/issues/342
Implement integration tests for topology
2024-02-22T10:42:00Z
Neil-Jocelyn Schark
Implement integration tests for topology
<!--- Provide a general summary of the issue in the Title above -->
## Description
<!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug -->
## Expected Behavior
<!--- Tell us what should h...
<!--- Provide a general summary of the issue in the Title above -->
## Description
<!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug -->
## Expected Behavior
<!--- Tell us what should happen -->
## Actual Behavior
<!--- Tell us what happens instead -->
## Possible Fix
<!--- Not obligatory, but suggest a fix or reason for the bug -->
## Steps to Reproduce
<!--- Provide a link to a live example, or an unambiguous set of steps to -->
<!--- reproduce this bug. Include code to reproduce, if relevant -->
1.
2.
3.
4.
## Context
<!--- How has this bug affected you? What were you trying to accomplish? -->
## Your Environment
<!--- Include as many relevant details about the environment you experienced the bug in -->
* Version used:
* Environment name and version (e.g. go v1.16.3 on FreeBSD 13.0-current):
* Server type and version:
* Operating System and version:
Neil-Jocelyn Schark
Neil-Jocelyn Schark
https://code.fbi.h-da.de/danet/gosdn/-/issues/341
Refactor GenericStore and try to combine two different implementations
2023-12-14T16:52:21Z
André Sterba
Refactor GenericStore and try to combine two different implementations
We have two different implementations of a `GenericStore`:
- The first one in the `store` package [here](https://code.fbi.h-da.de/danet/gosdn/-/blob/master/controller/store/genericStore.go?ref_type=heads)
- The second one in the `topolog...
We have two different implementations of a `GenericStore`:
- The first one in the `store` package [here](https://code.fbi.h-da.de/danet/gosdn/-/blob/master/controller/store/genericStore.go?ref_type=heads)
- The second one in the `topology` package [here](https://code.fbi.h-da.de/danet/gosdn/-/blob/master/controller/topology/store/genericStore.go?ref_type=heads)
They both use different constraints to be able to use them as generic.
https://code.fbi.h-da.de/danet/gosdn/-/issues/340
Implement integration tests for RBAC
2024-01-10T08:37:35Z
Fabian Seidl
Implement integration tests for RBAC
<!--- Provide a general summary of the issue in the Title above -->
## Description
<!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug -->
See the planned tests here: https://etherpad.h-d...
<!--- Provide a general summary of the issue in the Title above -->
## Description
<!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug -->
See the planned tests here: https://etherpad.h-da.de/p/aiIYo5YxXyHBPe-Z4jSA