From b82d5979461ced331d277aa7677b8cf1ca4abe08 Mon Sep 17 00:00:00 2001
From: Fabian Seidl <fabian.b.seidl@stud.h-da.de>
Date: Thu, 28 Apr 2022 15:51:20 +0200
Subject: [PATCH] improved readability
---
controller/rbac/role.go | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/controller/rbac/role.go b/controller/rbac/role.go
index 2deb123fd..e2e089753 100644
--- a/controller/rbac/role.go
+++ b/controller/rbac/role.go
@@ -51,13 +51,17 @@ func (r Role) GetPermissions() []string {
}
// RemovePermissionsFromRole takes permissions that should be removed from a role and updates the current permissions accordingly
-func (r Role) RemovePermissionsFromRole(permissionsToRemove []string) {
+func (r *Role) RemovePermissionsFromRole(permissionsToRemove []string) {
for _, permToRemove := range permissionsToRemove {
- for i, perm := range r.Permissions {
- if perm == permToRemove {
- r.Permissions = append(r.Permissions[:i], r.Permissions[i+1:]...)
- break
- }
+ r.removePermissionFromRoles(permToRemove)
+ }
+}
+
+func (r *Role) removePermissionFromRoles(permToRemove string) {
+ for i, perm := range r.Permissions {
+ if perm == permToRemove {
+ r.Permissions = append(r.Permissions[:i], r.Permissions[i+1:]...)
+ break
}
}
}
--
GitLab