From 7df775a0aaab938ec5f6e9569a3891d7ed5a841a Mon Sep 17 00:00:00 2001
From: Fabian Seidl <fabian.seidl@h-da.de>
Date: Thu, 22 Dec 2022 08:30:20 +0000
Subject: [PATCH] minor changes in descriptions and removed unnecessary param
in function
---
controller/event/event_test.go | 2 +-
controller/nucleus/networkElementService.go | 4 ++--
controller/nucleus/networkElementWatcher.go | 6 +++---
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/controller/event/event_test.go b/controller/event/event_test.go
index 9150bf0a2..011c6a8ed 100644
--- a/controller/event/event_test.go
+++ b/controller/event/event_test.go
@@ -158,7 +158,7 @@ func TestNewMneUpdateEvent(t *testing.T) {
}
if !reflect.DeepEqual(got.PathsAndValuesMap, tt.want.PathsAndValuesMap) {
- t.Errorf("NewMneUpdateEvent().Type = %v, want %v", got, tt.want)
+ t.Errorf("NewMneUpdateEvent().PathsAndValuesMap = %v, want %v", got, tt.want)
}
})
}
diff --git a/controller/nucleus/networkElementService.go b/controller/nucleus/networkElementService.go
index a41cdc351..310f45a02 100644
--- a/controller/nucleus/networkElementService.go
+++ b/controller/nucleus/networkElementService.go
@@ -137,7 +137,7 @@ func (s *NetworkElementService) UpdateModel(networkElementToUpdate networkelemen
return err
}
- // TODO (faseid): check if we want to add the paths here instead of empty map!
+ // TODO (faseid): check if we want to add the paths with values here instead of empty map!
pubEvent := event.NewMneUpdateEvent(networkElementToUpdate.ID(), map[string]string{})
if err := s.eventService.PublishEvent(NetworkElementEventTopic, pubEvent); err != nil {
go func() {
@@ -160,7 +160,7 @@ func (s *NetworkElementService) Update(networkElementToUpdate networkelement.Net
return err
}
- // TODO (faseid): check if we want to add the paths here instead of empty map!
+ // TODO (faseid): check if we want to add the paths with values here instead of empty map!
pubEvent := event.NewMneUpdateEvent(networkElementToUpdate.ID(), map[string]string{})
if err := s.eventService.PublishEvent(NetworkElementEventTopic, pubEvent); err != nil {
go func() {
diff --git a/controller/nucleus/networkElementWatcher.go b/controller/nucleus/networkElementWatcher.go
index af72cb625..60900feea 100644
--- a/controller/nucleus/networkElementWatcher.go
+++ b/controller/nucleus/networkElementWatcher.go
@@ -68,11 +68,11 @@ func (n *NetworkElementWatcher) SubToNetworkElements(paths [][]string, opts *gnm
}
for _, pnd := range pnds {
- n.subscribeToPndNetworkElements(pnd.ID().String(), pnd, opts)
+ n.subscribeToPndNetworkElements(pnd, opts)
}
}
-func (n *NetworkElementWatcher) subscribeToPndNetworkElements(pndID string, pnd networkdomain.NetworkDomain, opts *gnmi.SubscribeOptions) {
+func (n *NetworkElementWatcher) subscribeToPndNetworkElements(pnd networkdomain.NetworkDomain, opts *gnmi.SubscribeOptions) {
for _, mne := range pnd.NetworkElements() {
subID := uuid.New()
@@ -81,7 +81,7 @@ func (n *NetworkElementWatcher) subscribeToPndNetworkElements(pndID string, pnd
stopSubscribeCtx: stopContext,
stopFunc: cancel,
})
- go n.callSubscribe(stopContext, pndID, mne, opts)
+ go n.callSubscribe(stopContext, pnd.ID().String(), mne, opts)
}
}
--
GitLab