From 3978b4ebb95f00eb40dc40ec6d7c8a21736dc71f Mon Sep 17 00:00:00 2001
From: Malte Bauch <malte.bauch@stud.h-da.de>
Date: Fri, 31 Mar 2023 12:00:52 +0000
Subject: [PATCH] Apply suggestions
---
controller/northbound/server/networkElement.go | 17 -----------------
controller/nucleus/networkElementWatcher.go | 2 +-
2 files changed, 1 insertion(+), 18 deletions(-)
diff --git a/controller/northbound/server/networkElement.go b/controller/northbound/server/networkElement.go
index bd3904bb0..6b655e3ad 100644
--- a/controller/northbound/server/networkElement.go
+++ b/controller/northbound/server/networkElement.go
@@ -403,23 +403,6 @@ func fillMneBySpecificPath(nme networkelement.NetworkElement, path string) (*mne
return mne, nil
}
-// func genGnmiNotification(path *gpb.Path, val any) (*gpb.Notification, error) {
-// typedVal, err := ygot.EncodeTypedValue(val, gpb.Encoding_JSON_IETF)
-// if err != nil {
-// return nil, err
-// }
-// return &gpb.Notification{
-// Timestamp: time.Now().UnixNano(),
-// Update: []*gpb.Update{
-// {
-// Path: &gpb.Path{
-// Elem: path.GetElem(),
-// },
-// Val: typedVal,
-// },
-// },
-// }, nil
-// }
// GetPath gets a path on a mne.
func (n *NetworkElementServer) GetPath(ctx context.Context, request *mnepb.GetPathRequest) (*mnepb.GetPathResponse, error) {
diff --git a/controller/nucleus/networkElementWatcher.go b/controller/nucleus/networkElementWatcher.go
index ccfba7fd6..722351e43 100644
--- a/controller/nucleus/networkElementWatcher.go
+++ b/controller/nucleus/networkElementWatcher.go
@@ -39,7 +39,7 @@ type networkelementSubscriptionHelper struct {
stopFunc context.CancelFunc
}
-// NewNetworkElementWatcher takes a pndStore to subscribe to network element paths.
+// NewNetworkElementWatcher allows to subscribe to network element paths.
func NewNetworkElementWatcher(mneService networkelement.Service, eventService eventInterfaces.Service) *NetworkElementWatcher {
return &NetworkElementWatcher{
mneService: mneService,
--
GitLab