From 22ec2f5e9f3e3ff80f5b6716a82a208581c63d19 Mon Sep 17 00:00:00 2001
From: Andre Sterba <andre.sterba@stud.h-da.de>
Date: Thu, 7 Jul 2022 13:00:24 +0000
Subject: [PATCH] Speedup tests by running in parallel

See merge request danet/gosdn!346
---
 controller/nucleus/device_test.go             |  2 ++
 .../nucleus/principalNetworkDomain_test.go    | 20 +++++++++++++++++++
 .../integration/nucleusIntegration_test.go    |  2 ++
 3 files changed, 24 insertions(+)

diff --git a/controller/nucleus/device_test.go b/controller/nucleus/device_test.go
index 885f21ba3..2ce886361 100644
--- a/controller/nucleus/device_test.go
+++ b/controller/nucleus/device_test.go
@@ -98,7 +98,9 @@ func TestNewDevice(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
+		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
 			resp, err := NewDevice(tt.args.name, uuid.Nil, tt.args.opts, tt.args.sbi)
 			if (err != nil) != tt.wantErr {
 				t.Errorf("NewDevice() error = %v, wantErr %v", err, tt.wantErr)
diff --git a/controller/nucleus/principalNetworkDomain_test.go b/controller/nucleus/principalNetworkDomain_test.go
index 0cd9c3b14..99e78bf61 100644
--- a/controller/nucleus/principalNetworkDomain_test.go
+++ b/controller/nucleus/principalNetworkDomain_test.go
@@ -325,7 +325,9 @@ func Test_pndImplementation_RemoveDevice(t *testing.T) {
 	}
 
 	for _, tt := range tests {
+		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
 			pnd := newPnd()
 			sbi, err := NewSBI(spb.Type_TYPE_OPENCONFIG)
 			if err != nil {
@@ -366,7 +368,9 @@ func Test_pndImplementation_RemoveSbi(t *testing.T) {
 		{name: "fails", args: args{id: uuid.New()}, wantErr: true},
 	}
 	for _, tt := range tests {
+		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
 			eventService := eventservice.NewMockEventService()
 			sbiStore := NewMemorySbiStore()
 			deviceStore := NewMemoryDeviceStore()
@@ -432,7 +436,9 @@ func Test_pndImplementation_RemoveSbiWithAssociatedDevices(t *testing.T) {
 		{name: "exclusively remove associated devices", args: args{id: defaultSbiID}, wantErr: false},
 	}
 	for _, tt := range tests {
+		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
 			eventService := eventservice.NewMockEventService()
 			sbiStore := NewMemorySbiStore()
 			deviceStore := NewMemoryDeviceStore()
@@ -535,7 +541,9 @@ func Test_pndImplementation_Request(t *testing.T) {
 	}
 
 	for _, tt := range tests {
+		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
 			sbiService := NewGenericService[southbound.SouthboundInterface]()
 			deviceService := NewGenericService[device.Device]()
 
@@ -619,7 +627,9 @@ func Test_pndImplementation_RequestAll(t *testing.T) {
 	}
 
 	for _, tt := range tests {
+		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
 			sbiService := NewGenericService[southbound.SouthboundInterface]()
 			deviceService := NewGenericService[device.Device]()
 
@@ -760,7 +770,9 @@ func Test_pndImplementation_ChangeOND(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
+		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
 			pnd := newPnd()
 			if err := pnd.addSbi(&OpenConfig{id: defaultSbiID}); err != nil {
 				t.Error(err)
@@ -847,7 +859,9 @@ func Test_pndImplementation_GetDevice(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
+		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
 			foundDevice, err := pnd.GetDevice(tt.args.uuid.String())
 			if (err != nil) != tt.wantErr {
 				t.Errorf("GetDevice() error = %v, wantErr %v", err, tt.wantErr)
@@ -916,7 +930,9 @@ func Test_pndImplementation_GetDeviceByName(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
+		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
 			foundDevice, err := pnd.GetDevice(tt.args.name)
 			if (err != nil) != tt.wantErr {
 				t.Errorf("GetDeviceByName() error = %v, wantErr %v", err, tt.wantErr)
@@ -947,7 +963,9 @@ func Test_pndImplementation_Confirm(t *testing.T) {
 	}
 
 	for _, tt := range tests {
+		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
 			sbiService := NewGenericService[southbound.SouthboundInterface]()
 			deviceService := NewGenericService[device.Device]()
 
@@ -1179,7 +1197,9 @@ func Test_pndImplementation_saveGoStructsToFile(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
+		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
 			err := saveStreamToFile(tt.args.client, util.GoStructName, tt.args.id)
 			if (err != nil) != tt.wantErr {
 				t.Errorf("saveGoStructsToFile() error = %v, wantErr %v", err, tt.wantErr)
diff --git a/controller/test/integration/nucleusIntegration_test.go b/controller/test/integration/nucleusIntegration_test.go
index b85058a46..36b977a62 100644
--- a/controller/test/integration/nucleusIntegration_test.go
+++ b/controller/test/integration/nucleusIntegration_test.go
@@ -225,7 +225,9 @@ func TestGnmi_SetValidIntegration(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
+		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
 			cuid, err := pnd.ChangeOND(device.ID(), tt.apiOp, tt.path, tt.value)
 			if err != nil {
 				t.Error(err)
-- 
GitLab