diff --git a/nucleus/cli-handling.go b/nucleus/cli-handling.go index af0912ccd55bac6c97957911898e8af1a99f27ab..e6d843eb3f2120b4e4fc54c14da9534600d6b265 100644 --- a/nucleus/cli-handling.go +++ b/nucleus/cli-handling.go @@ -9,10 +9,10 @@ package nucleus import ( pb "code.fbi.h-da.de/cocsn/gosdn/cliInterface" + "code.fbi.h-da.de/cocsn/gosdn/log" "code.fbi.h-da.de/cocsn/gosdn/restconf/client/ciena" "context" "google.golang.org/grpc" - "code.fbi.h-da.de/cocsn/gosdn/log" "net" ) @@ -23,12 +23,12 @@ type server struct { } func (s *server) SayHello(ctx context.Context, in *pb.HelloRequest) (*pb.HelloReply, error) { - log.Info("Received: %v", in.GetName()) + log.Info("Received: ", in.GetName()) return &pb.HelloReply{Message: "Hello " + in.GetName(), GoSDNInfo: "goSDN in version: DEVELOP"}, nil } func (s *server) Shutdown(ctx context.Context, in *pb.ShutdownRequest) (*pb.ShutdownReply, error) { - log.Info("Shutdown Received: %v", in.GetName()) + log.Info("Shutdown Received: ", in.GetName()) s.core.IsRunning <- false return &pb.ShutdownReply{Message: "Shutdown " + in.GetName()}, nil } @@ -38,21 +38,21 @@ func getCLIGoing(core *Core) { // Boot-up the control interface for the cli cliControlListener, err := net.Listen("tcp", core.config.CliSocket) if err != nil { - log.Fatal("failed to listen: %v", err) + log.Fatal(err) } cliControlServer := grpc.NewServer() pb.RegisterGrpcCliServer(cliControlServer, &server{core: core}) if err := cliControlServer.Serve(cliControlListener); err != nil { - log.Fatal("failed to serve: %v", err) + log.Fatal(err) } log.Info("Started: GetCLIGoing") } // SBI specific calls, by now TAPI only func (s *server) TAPIGetEdge(ctx context.Context, in *pb.TAPIRequest) (*pb.TAPIReply, error) { - log.Info("Received: %v", in.GetName()) + log.Info("Received: ", in.GetName()) if err := s.core.clients["ciena-mcp"].(*ciena.MCPClient).GetNodes(); err != nil { log.Error(err) return &pb.TAPIReply{Message: "TAPI error"}, nil @@ -61,7 +61,7 @@ func (s *server) TAPIGetEdge(ctx context.Context, in *pb.TAPIRequest) (*pb.TAPIR } func (s *server) TAPIGetEdgeNode(ctx context.Context, in *pb.TAPIRequest) (*pb.TAPIReply, error) { - log.Info("Received: %v", in.GetName()) + log.Info("Received: ", in.GetName()) if err := s.core.clients["ciena-mcp"].(*ciena.MCPClient).GetNodeEdgePoints(); err != nil { log.Error(err) return &pb.TAPIReply{Message: "TAPI error"}, nil @@ -70,7 +70,7 @@ func (s *server) TAPIGetEdgeNode(ctx context.Context, in *pb.TAPIRequest) (*pb.T } func (s *server) TAPIGetLink(ctx context.Context, in *pb.TAPIRequest) (*pb.TAPIReply, error) { - log.Info("Received: %v", in.GetName()) + log.Info("Received: ", in.GetName()) if err := s.core.clients["ciena-mcp"].(*ciena.MCPClient).GetLinks(); err != nil { log.Error(err) return &pb.TAPIReply{Message: "TAPI error"}, nil diff --git a/nucleus/controller.go b/nucleus/controller.go index 5f094178b6fffcc1c257ed6393a78e88e60766b7..9cb0b781f6acb533db6c7d4a86e561f1e91869da 100644 --- a/nucleus/controller.go +++ b/nucleus/controller.go @@ -62,7 +62,7 @@ func (c *Core) AttachDatabase() { func (c *Core) Shutdown() { stopIt := <- c.IsRunning - if(stopIt == false) { + if !stopIt { log.Debug("Shutdown() received action to shutdown") }else { log.Debug("Shutdown() received something else.")