From 299f0481c302d5927b6f11e92a7cdb9c90b5dcd6 Mon Sep 17 00:00:00 2001
From: Timo Furrer <tfurrer@gitlab.com>
Date: Mon, 4 Nov 2024 15:47:19 +0100
Subject: [PATCH] Define on_success as default rule

---
 templates/apply.yml        | 2 +-
 templates/delete-state.yml | 2 +-
 templates/destroy.yml      | 2 +-
 templates/fmt.yml          | 2 +-
 templates/plan.yml         | 2 +-
 templates/test.yml         | 2 +-
 templates/validate.yml     | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/templates/apply.yml b/templates/apply.yml
index fc1546f..adaec37 100644
--- a/templates/apply.yml
+++ b/templates/apply.yml
@@ -92,7 +92,7 @@ spec:
       # FIXME: eventually, we'll want to define `null` as the default,
       # but this is NOT support yet, see
       # https://gitlab.com/gitlab-org/gitlab/-/issues/440468
-      default: []
+      default: [{when: on_success}]
       type: array
       description: 'Defines the `rules` of the job.'
 
diff --git a/templates/delete-state.yml b/templates/delete-state.yml
index d3f0c97..3305cc6 100644
--- a/templates/delete-state.yml
+++ b/templates/delete-state.yml
@@ -19,7 +19,7 @@ spec:
       # FIXME: eventually, we'll want to define `null` as the default,
       # but this is NOT support yet, see
       # https://gitlab.com/gitlab-org/gitlab/-/issues/440468
-      default: []
+      default: [{when: on_success}]
       type: array
       description: 'Defines the `rules` of the job.'
 
diff --git a/templates/destroy.yml b/templates/destroy.yml
index bc18977..4519979 100644
--- a/templates/destroy.yml
+++ b/templates/destroy.yml
@@ -92,7 +92,7 @@ spec:
       # FIXME: eventually, we'll want to define `null` as the default,
       # but this is NOT support yet, see
       # https://gitlab.com/gitlab-org/gitlab/-/issues/440468
-      default: []
+      default: [{when: on_success}]
       type: array
       description: 'Defines the `rules` of the job.'
 
diff --git a/templates/fmt.yml b/templates/fmt.yml
index afaf8ac..cba5d83 100644
--- a/templates/fmt.yml
+++ b/templates/fmt.yml
@@ -88,7 +88,7 @@ spec:
       # FIXME: eventually, we'll want to define `null` as the default,
       # but this is NOT support yet, see
       # https://gitlab.com/gitlab-org/gitlab/-/issues/440468
-      default: []
+      default: [{when: on_success}]
       type: array
       description: 'Defines the `rules` of the job.'
 
diff --git a/templates/plan.yml b/templates/plan.yml
index 33972b5..9987fcd 100644
--- a/templates/plan.yml
+++ b/templates/plan.yml
@@ -91,7 +91,7 @@ spec:
       # FIXME: eventually, we'll want to define `null` as the default,
       # but this is NOT support yet, see
       # https://gitlab.com/gitlab-org/gitlab/-/issues/440468
-      default: []
+      default: [{when: on_success}]
       type: array
       description: 'Defines the `rules` of the job.'
 
diff --git a/templates/test.yml b/templates/test.yml
index 729acea..1978669 100644
--- a/templates/test.yml
+++ b/templates/test.yml
@@ -88,7 +88,7 @@ spec:
       # FIXME: eventually, we'll want to define `null` as the default,
       # but this is NOT support yet, see
       # https://gitlab.com/gitlab-org/gitlab/-/issues/440468
-      default: []
+      default: [{when: on_success}]
       type: array
       description: 'Defines the `rules` of the job.'
 
diff --git a/templates/validate.yml b/templates/validate.yml
index fdb431c..22b1ab5 100644
--- a/templates/validate.yml
+++ b/templates/validate.yml
@@ -84,7 +84,7 @@ spec:
       # FIXME: eventually, we'll want to define `null` as the default,
       # but this is NOT support yet, see
       # https://gitlab.com/gitlab-org/gitlab/-/issues/440468
-      default: []
+      default: [{when: on_success}]
       type: array
       description: 'Defines the `rules` of the job.'
 
-- 
GitLab